Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp package Error "Task never defined: package" #349

Closed
james7342 opened this issue Apr 17, 2023 · 4 comments
Closed

gulp package Error "Task never defined: package" #349

james7342 opened this issue Apr 17, 2023 · 4 comments
Milestone

Comments

@james7342
Copy link

Describe the bug

Running though the Videos and Documentation and ran into an error with the "gulp package" command

To Reproduce

Follow Video 01 Intro- Last thing the video describes doing is building the project. Receive error message noted below.

Expected behavior

Build/Package is created.

Screenshots

N/A

Errors

C:\inetpub\wwwroot\dnndev.me\Portals_default\Skins\Test\nvQuickTheme>gulp package
[10:37:13] Using gulpfile C:\inetpub\wwwroot\dnndev.me\Portals_default\Skins\Test\nvQuickTheme\gulpfile.js
[10:37:13] Task never defined: package
[10:37:13] To list available tasks, try running: gulp --tasks

Additional context

Looking at the --tasks this looks to be a documentation error as the task looks like the name has been changed to "packageTheme" and is case sensitive.

C:\inetpub\wwwroot\dnndev.me\Portals_default\Skins\Test\nvQuickTheme>gulp packagetheme
[10:45:10] Using gulpfile C:\inetpub\wwwroot\dnndev.me\Portals_default\Skins\Test\nvQuickTheme\gulpfile.js
[10:45:10] Task never defined: packagetheme
[10:45:10] To list available tasks, try running: gulp --tasks

C:\inetpub\wwwroot\dnndev.me\Portals_default\Skins\Test\nvQuickTheme>gulp packageTheme
[10:45:24] Using gulpfile C:\inetpub\wwwroot\dnndev.me\Portals_default\Skins\Test\nvQuickTheme\gulpfile.js
[10:45:24] Starting 'packageTheme'...
[10:45:24] Starting 'cleandist'...
[10:45:24] dist folder cleaned up!
[10:45:25] Finished 'cleandist' after 173 ms
[10:45:25] Starting 'fontsInit'...
[10:45:25] 20 font files distributed!
[10:45:25] Finished 'fontsInit' after 150 ms
[10:45:25] Starting 'faFontsInit'...
[10:45:25] 8 FontAwesome files distributed!
[10:45:25] Finished 'faFontsInit' after 56 ms
[10:45:25] Starting 'faCssInit'...
[10:45:25] 1 CSS files distributed!
[10:45:25] Finished 'faCssInit' after 14 ms

https://nvisionative.github.io/nvQuickTheme/Commands.html

@david-poindexter
Copy link
Member

@james7342 apologies for the confusion. Yes, this is a documentation issue. The gulp task was previously gulp package.
Now package is a reserved word, so we had to change it to gulp packageTheme. The documentation was never updated to reflect this change. We'll leave this issue in place as a reminder to update the documentation. Of course, PRs are welcome. 😉

@david-poindexter
Copy link
Member

Actually, a PR was already submitted and merged into develop to address this (see #340). It will reflect on the GitHub pages site as soon as it is merged into main. We'll do that for the next release. I'll go ahead and close this issue now. Thanks for reporting it!

@david-poindexter david-poindexter added this to the 3.1.0 milestone Apr 17, 2023
@james7342
Copy link
Author

@david-poindexter Thank You!!.. I guess I should have looked at resolved issue prior.

@david-poindexter
Copy link
Member

No worries at all. We appreciate the reminder about this issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants