-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No tests found error in react project with create-react-app #74
Comments
Hi @giuxtaposition, |
@Jamie-505 Good, but it does not suit case with default create-react-app case. It should read nested dependencies, or try to run yarn test command to determinate test runner. I tried you fork. |
this is very relevant and necessary. How are things progressing on this issue? |
I can get the detection to work if I locally adapt the |
Maybe I didn't get it completely. but why do we need jest detection to determine if something is a test file? isn't the pattern matching here enough? I removed jest detection from my local branch and it works great. (I work on 3 considerable-sized typescript projects and one of them is mono repo) |
I don't think so. That is just a file name pattern, right? There are many other testing frameworks which use similar naming concepts. Like Vitest for example (very related I know, but would be a different |
@weilbith Thanks. I get it now. |
As the title says, the current strategy of checking that jest is a dependency in the package.json does not work with project bootstrapped with create-react-app because jest is included as a dependency of react-scripts.
As a workaround I added it as explicit dependency in my project, but isn't there a better solution?
The text was updated successfully, but these errors were encountered: