Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests having warnings are marked as failed #53

Closed
olzhasar opened this issue Jun 23, 2023 · 2 comments · Fixed by #54
Closed

Tests having warnings are marked as failed #53

olzhasar opened this issue Jun 23, 2023 · 2 comments · Fixed by #54

Comments

@olzhasar
Copy link
Contributor

Hi,
Thank you for neotest-go, great work!

I'm experiencing an issue when tests are being marked as failed when they produce warnings, even though tests themselves pass:
image

Here is the output from go test command:

➜  go-fileserver git:(registry) ✗ go test ./registry -count=1
# github.com/olzhasar/go-fileserver/registry.test
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
ok      github.com/olzhasar/go-fileserver/registry      0.880s
@sergii4
Copy link
Collaborator

sergii4 commented Jun 27, 2023

Hi @olzhasar, what are the steps to reproduced this issue?

@olzhasar
Copy link
Contributor Author

olzhasar commented Jun 27, 2023

@sergii4
I believe these kind of warnings can be generated when go is calling C code.

I don't know the internals well, so no easy way to reproduce that I am aware of.
I am experiencing these warnings when importing mattn/go-sqlite3 package on MacOS. You can try to run any go test with this package imported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants