Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Contributors #37

Open
akinsho opened this issue Mar 10, 2023 · 8 comments
Open

New Contributors #37

akinsho opened this issue Mar 10, 2023 · 8 comments

Comments

@akinsho
Copy link
Collaborator

akinsho commented Mar 10, 2023

Hey all,

So for a little bit of context I created this neotest extension off the back of @rcarriga great plugin as I was keen to use neotest with go. Unfortunately I don't currently work very much with go ATM (which could change) but in the meantime it would be great if anyone who is actively using this plugin and wants to help improve it could step forward and @rcarriga can hopefully add them to project so they can merge changes etc. and aren't dependent on me. I'm not completely gone but definitely not worth poking me or waiting on me as I'm also not actively monitoring this repo.

@sergii4 I've noticed you've been active on some issues. Would this interest you?

@sergii4
Copy link
Collaborator

sergii4 commented Mar 10, 2023

Hi @akinsho, thank you, I am definitely interested in. I can pop in now and then, check issues and probably would need some help with PR. However, I think I understood how plugin works, so I am in.

@akinsho
Copy link
Collaborator Author

akinsho commented Mar 10, 2023

That's great, hopefully once @rcarriga is free he can add you as a collaborator as well 👍🏿 . I'm around if you have any questions but will probably be pretty slow to respond/will definitely not notice personally if something is breaking in the plugin since I don't currently use it very much

@rcarriga
Copy link
Contributor

Thanks for flagging @akinsho, and thanks @sergii4 for putting yourself forward! I've added you as a collaborator to neoteset-go 😄

I'm not very familiar with Go so probably won't be much help on Go specifics, but feel free to ping me as well if you need help with Neotest internals.

@sergii4
Copy link
Collaborator

sergii4 commented Mar 12, 2023

@rcarriga @akinsho thank you, I am happy to join 😄

@Micloroc
Copy link

Micloroc commented May 6, 2023

Hello guys!

This would be my first time contributing to a project. I would like to open a PR fixing an issue when executing tests that contain complex build tags but it seems that I don't have permissions to push a new branch to the repository.

Do I need to be a contributor for that? Should I follow any contribution guide regarding things like git flow, naming, etc?

Thanks in advance!

cc: @akinsho

@sergii4
Copy link
Collaborator

sergii4 commented May 6, 2023

@Micloroc
Copy link

Micloroc commented May 6, 2023

Great, I've already opened it #46, thank you!

@fredrikaverpil
Copy link

I've actually had a hard time fixing some of the issues I've had with neotest-go due to how the tests are managed. I've taken a stab at learning the neotest interface a bit better and taken a different approach which actually mitigates a lot of issues, which has resulted in another neotest adapter for go: https://github.com/fredrikaverpil/neotest-golang

I'm using this adapter of mine daily, at work, dogfooding myself and I've also found a few upstream issues. Feel free to take any inspiration from this project, or join me in trying to ironing out the final kinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants