feat(introspector): Todo-introspector improvements #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added documentation so it shows in the wiki * Made it a lot more configurable
mtrajano
commented
Jul 26, 2024
| -- Defaults to the following: `done`. | ||
| completed_statuses = { | ||
| "done", | ||
| }, |
There was a problem hiding this comment.
Figured it's technically possible for a user to count something like "cancelled" towards completed tasks
mtrajano
commented
Jul 26, 2024
| total, | ||
| (total ~= 0 and math.floor((completed / total) * 100) or 0) | ||
| ) | ||
| -- stylua: ignore end |
There was a problem hiding this comment.
To keep parameters above in multiple lines, it was formatting into a single line method call (making it harder to read)
|
Looks good to me, thank you! Haven't been able to break it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation and configurability to the todo-introspector. By default should behave as the old one, but you now have the ability to configure:
Also closes #1512 in terms of documentation needed