fix(dirman): add raw_path
option to work with arbitrary filetype
#1143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core.dirman.utils.expand_path
is the function to resolve filepath with workspace notation ($<workspace>/
).This should work with arbitrary file type as it will be used to resolve files in for example
.image $/relative/path/to/image.png
, but currently, it is hardcoded to append.norg
after the file path.I've added an argument
raw_path
which, when is true, does not append the norg extension.The previous calls to this function does not specify this arg, (hence nil) so we should have backwards compatibility.
Note
neorg/lua/neorg/modules/core/dirman/utils/module.lua
Lines 45 to 47 in 98f390d
Not in the scope of this PR but I don't think this works on Windows. I don't have an environment to test Windows so I'll leave it to someone else for a fix.
Possibly related: #241