fix(summary): escape ws_root special characters #1012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey there :)
i was just trying to debug the links in the summary module not being generated properly.
the issue is that the links are generated as ones relative to current workspace root
( the format of
:$/path/from/current/workspace:
).however the actuals paths post gsub remain full paths.
for debugging i modified the module.lua like so:
and that gave me this:
and so on for every file. \
with ws_root being:
/home/cherry-cat/Notes/General
\i figured out that the issue lies in the special character
in my user name not being escaped (._.)
so i added this bit here before the norgname
i am legit the worst at regex. and idk if these characters can even be part of a path so probably it's good if someone reads this regex.
sorry also for not opening an issue i guess. i thought maybe this is ok because its just 2 lines that are changed pretty straight forwardly.
best regards 👋