Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA not using aria-valuemax #6906

Closed
thbt opened this issue Feb 22, 2017 · 8 comments
Closed

NVDA not using aria-valuemax #6906

thbt opened this issue Feb 22, 2017 · 8 comments
Labels
ARIA close/duplicate p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

Comments

@thbt
Copy link

thbt commented Feb 22, 2017

NVDA only seems to read the aria-valuenow attribute, and ignore the aria-valuemax value. For example, if I have a progress-bar with aria-valuenow=150 and aria-valuemax=200, it will read 150, and if I have a progress-bar with aria-valuenow=150 and aria-valuemax=150, it will also read 150, the end user have no indication of the current progress.

@feerrenrut
Copy link
Contributor

Could you provide a test case for this (self contained and zipped html file) or example on jsfiddle or a similar service?

@thbt
Copy link
Author

thbt commented Feb 22, 2017

Sure : JSFiddle

@feerrenrut
Copy link
Contributor

Thanks.
Using Version: next-13881,c025b508 I can reproduce this.

The JSFiddle reads:

  • "progress bar 25"
  • "progress bar 50"
  • "progress bar 150"
  • "progress bar 150"

When viewed as a percentage, these would be 25%, 50%, 75%, 100%. Perhaps instead NVDA could output:

  • "progress bar 25 of 100 25%"
  • "progress bar 50 of 100 50%"
  • "progress bar 150 of 200 75%"
  • "progress bar 150 of 150 100%"

@jcsteh what do you think? Perhaps this could be addressed with the aria project?

@feerrenrut feerrenrut added p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority ARIA labels Feb 23, 2017
@feerrenrut
Copy link
Contributor

Aria documentation This does not seem to be new in aria 1.1

@PratikP1
Copy link

PratikP1 commented Feb 23, 2017 via email

@jcsteh
Copy link
Contributor

jcsteh commented Mar 7, 2017

  • The need for max has been mentioned, but not min. If min is 100, now is 200 and max is 300, "200 of 300" is incorrect. Arguably, it's even worse, since now you're misleading the user (as opposed to assuming the min and max can be determined some other way).
  • Constantly hearing "200 minimum 100 maximum 300" is going to be extremely annoying for the user, especially for progress bars.
  • For sliders:
    • I think the min and max should be reported when the slider gets focus, not when the value changes. So, you might hear "slider minimum 100 maximum 300 value 200". This eliminates extraneous verbosity.
    • If valuetext is present, only valuetext should be reported, none of the others.
  • For progress bars:
    • We should certainly normalise the values for progress bar beeps.
    • We should consider always normalising to a percentage even for speech. There's no opportunity to report the minimum and maximum just once for a progress bar like there is for sliders (since progress bars don't get focus). Continually reporting them is just not an option; the verbosity would be insane.

@Dan503
Copy link

Dan503 commented Jul 24, 2018

Another use case:

  • role="progressbar"
  • Step 1 of 5
  • Updates step progress dynamically as the user fills in questions
  • aria-valuemin="1"
  • aria-valuemax="5"
  • aria-valuenow="1"

If aria-valuenow hits a value of 5 NVDA currently treats it like the user is only 5% through the form. In reality NVDA should treat it like they are 100% through the form.

@Adriani90
Copy link
Collaborator

The same applies probably also for spin buttons and other elements with mina nd max values.

I am closing in favor of #16678 which contains technical information on how to start implementing this.

@Adriani90 Adriani90 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARIA close/duplicate p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Development

No branches or pull requests

6 participants