Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Accordion): solve the shift between buttons when they are opened #379

Merged
merged 4 commits into from
Jul 3, 2023
Merged

fix(Accordion): solve the shift between buttons when they are opened #379

merged 4 commits into from
Jul 3, 2023

Conversation

Haythamasalama
Copy link
Contributor

@Haythamasalama Haythamasalama commented Jul 3, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Jul 3, 2023

@Haythamasalama is attempting to deploy a commit to the Nuxt Labs Team on Vercel.

A member of the Team first needs to authorize it.

@Haythamasalama
Copy link
Contributor Author

@benjamincanac done

@Haythamasalama
Copy link
Contributor Author

Is there a way to solve Vercel's action? It's noisy to see that it always shows ❌. However, I give it permissions.

@benjamincanac
Copy link
Member

I've disabled Vercel Git Fork Protection, we'll see if it fixes the issues! I've pushed a small fix to harmonize the panel spacing.

Besides that, it does fix the shifting issue, thanks 😊

@benjamincanac benjamincanac merged commit eaf0043 into nuxt:dev Jul 3, 2023
@Haythamasalama Haythamasalama deleted the fix/accordion-shift-between-button branch July 3, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haythamasalama @benjamincanac