Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add loading state #259

Merged
merged 10 commits into from
Jun 12, 2023

Conversation

Haythamasalama
Copy link
Contributor

@Haythamasalama Haythamasalama commented Jun 6, 2023

Loading State in Table

The loading state is used to display loading in a table, typically when fetching data asynchronously. It is commonly used in scenarios where data needs to be retrieved from an API or server before it can be displayed.

feat:

  • Ability to customize icon and label
  • Ability to customize a slot for loading

@nuxt-studio-dev
Copy link

nuxt-studio-dev bot commented Jun 6, 2023

Live Preview ready!

Name Edit Preview Latest Commit
ui Edit on Studio ↗︎ View Live Preview b7b0c39

@nuxt-studio
Copy link

nuxt-studio bot commented Jun 6, 2023

Live Preview ready!

Name Edit Preview Latest Commit
ui Edit on Studio ↗︎ View Live Preview 1c851b4

@vercel
Copy link

vercel bot commented Jun 6, 2023

@Haythamasalama is attempting to deploy a commit to the Nuxt Labs Team on Vercel.

A member of the Team first needs to authorize it.

@benjamincanac benjamincanac changed the title feat(table): add loading state 🔃 feat(table): add loading state Jun 9, 2023
@benjamincanac
Copy link
Member

@Haythamasalama Would you mind fixing the conflicts due to the #260 merge?

@Haythamasalama
Copy link
Contributor Author

@benjamincanac done

@benjamincanac
Copy link
Member

I've made a few changes to your PR, let me know what you think 😊

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jun 12, 2023 9:59am

@Haythamasalama
Copy link
Contributor Author

I've made a few changes to your PR, let me know what you think 😊
@benjamincanac

Nice, I ❤️ your final touch
I realized the color loader in light mode did not work, so I fixed that.
Now i will work on Disclosure

@benjamincanac benjamincanac merged commit 4741532 into nuxt:dev Jun 12, 2023
@Haythamasalama Haythamasalama deleted the feat/data-table-loading-state branch June 12, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants