chore: Improve lighthouse score (#86)

* fix(seo): support configurable base url * fix: improve Twitter card accessibility * remove empty fr content * chore: use docus url from settings Co-authored-by: Sébastien Chopin <[email protected]>
nuxt-themes · Feb 22, 2021 · 31654a0 · 31654a0 · vercel · Feb 22, 2021
1 parent 81347d1
commit 31654a0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/docs/components/global/Tweet.vue b/docs/components/global/Tweet.vue
@@ -1,8 +1,8 @@
 <template>
-  <div class="tweet">
+  <blockquote class="tweet">
     <div class="author flex mb-4">
       <a :href="profileUrl" target="_blank" rel="noopener noreferrer">
-        <img :src="avatar" class="w-6 h-6 rounded-full" :class="{'h-12 w-12': layout === 'tweet'}" />
+        <img :src="avatar" :alt="name" class="w-6 h-6 rounded-full" :class="{'h-12 w-12': layout === 'tweet'}" />
       </a>
       <div class="ml-2 flex-1">
         <a :href="profileUrl" target="_blank" rel="noopener noreferrer">
@@ -19,7 +19,7 @@
         </template>
       </div>
       <a v-if="layout === 'tweet'" :href="tweetUrl" target="_blank" rel="noopener noreferrer">
-        <IconTwitter class="text-blue-500" />
+        <IconTwitter title="View on Twitter" role="img" class="text-blue-500" />
       </a>
     </div>
     <div class="content">
@@ -34,7 +34,7 @@
         {{ $d(createdAt, "long") }}
       </a>
     </div>
-  </div>
+  </blockquote>
 </template>
 
 <script>

diff --git a/docs/content/fr/1.index.md b/docs/content/fr/1.index.md
diff --git a/theme/nuxt.config.js b/theme/nuxt.config.js
@@ -70,6 +70,7 @@ export default docusOptions => ({
     classSuffix: ''
   },
   i18n: {
+    baseUrl: ({ $docus }) => $docus?.settings?.url || '',
     locales: [{
       code: 'en',
       iso: 'en-US',