fix(defineShortcuts): support minus -
key
#962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Fixes #954
β Type of change
π Description
Here is a fix to the
-
shortcut usingdefineShortcuts
, which has been broken when chained shortcuts were introduced.Though, it fixes a bug but leverages some issues on more advanced usecases (complex keys).
The current separators for combined and chained shortcuts are
_
and-
. And their combination in the same key is quite complex.We could image being able to handle
_-_
(two hits on_
), ore_-
(combination ofe
and-
). A non-exhaustive list of shortcuts that should work IMO:['e_-', 'e__', '_-_', '---', '_--']
.But let's fix this current issue and potentially create a new one for advanced shortcuts, or wait to see if the demand actually exists.
π Checklist