Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): missing component imports #608

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix(Table): missing component imports #608

merged 2 commits into from
Sep 5, 2023

Conversation

aditio-eka
Copy link
Contributor

No description provided.

@stackblitz
Copy link

stackblitz bot commented Sep 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Sep 5, 2023 1:15am

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjamincanac benjamincanac changed the title Fix missing component in Table caused by prefix config fix(Table): missing component imports Sep 4, 2023
@aditio-eka
Copy link
Contributor Author

Nice catch! Those should also be defined in the components key like https://github.com/nuxtlabs/ui/blob/dev/src/runtime/components/navigation/VerticalNavigation.vue#L58

thanks for feedback, i have updated my code

@benjamincanac benjamincanac merged commit fc386ac into nuxt:dev Sep 5, 2023
Haythamasalama pushed a commit to Haythamasalama/ui that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants