Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Avatar): bind $attrs on AvatarFallback #2933

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

HugoRCD
Copy link
Collaborator

@HugoRCD HugoRCD commented Dec 18, 2024

πŸ”— Linked issue

resolve #2923

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When the src of the image in UAvatar failed to get resolved for any reason (non-existent resource, network error, refused connection from the requested host, etc), it no longer triggered the expansion of the UDropdownMenu.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title fix(Avatar): bind $attrs on AvatarFallback fix(Avatar): bind $attrs on AvatarFallback Dec 18, 2024
Copy link

pkg-pr-new bot commented Dec 19, 2024

npm i https://pkg.pr.new/@nuxt/ui@2933

commit: 4e6b596

@benjamincanac benjamincanac merged commit 7f64198 into nuxt:v3 Dec 19, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

@benjamincanac benjamincanac added the v3 #1289 label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UAvatar with non-resolved src fails to trigger UDropdownMenu
2 participants