Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): error with renderer when colorMode is disabled #2792

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

romhml
Copy link
Collaborator

@romhml romhml commented Nov 27, 2024

πŸ”— Linked issue

Resolves #2788

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fixes an issue with the devtools when colorMode is disabled by using @vueuse instead of the colorMode module in the devtools renderer.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

cloudflare-workers-and-pages bot commented Nov 27, 2024

Deploying ui3 with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 63f32cb
Status:Β βœ…Β  Deploy successful!
Preview URL: https://9025ffe9.ui-6q2.pages.dev
Branch Preview URL: https://fix-devtools-colormode.ui-6q2.pages.dev

View logs

Copy link

pkg-pr-new bot commented Nov 27, 2024

npm i https://pkg.pr.new/@nuxt/ui@2792

commit: 63f32cb

@benjamincanac benjamincanac changed the title fix(devtools): error with renderer when colorMode is disabled fix(devtools): error with renderer when colorMode is disabled Nov 28, 2024
@benjamincanac benjamincanac merged commit f06fbaf into v3 Nov 28, 2024
3 checks passed
@benjamincanac benjamincanac deleted the fix/devtools-colormode branch November 28, 2024 09:51
@benjamincanac
Copy link
Member

Thanks @romhml! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting colorMode to false triggers an error
2 participants