Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Form): apply transformations #2550

Merged
merged 11 commits into from
Nov 12, 2024
Merged

feat(Form): apply transformations #2550

merged 11 commits into from
Nov 12, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Nov 7, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this PR is port from component Form v2 #2460

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar requested a review from romhml November 7, 2024 02:48
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 7, 2024 •
edited
Loading

Deploying ui3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58da2e6
Status: ✅  Deploy successful!
Preview URL: https://6bde799a.ui-6q2.pages.dev
Branch Preview URL: https://feat-form-apply-transformati.ui-6q2.pages.dev

View logs

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 7, 2024 •
edited
Loading 

pnpm add https://pkg.pr.new/@nuxt/ui@2550

commit: 58da2e6

@rdjanuar rdjanuar added enhancement New feature or request v3 #1289 labels Nov 7, 2024
@rdjanuar rdjanuar requested a review from romhml November 9, 2024 18:02
romhml
romhml approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@romhml romhml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rdjanuar!

@benjamincanac
Copy link
Member

benjamincanac commented Nov 12, 2024 •
edited
Loading

@rdjanuar Any idea on the typecheck failing? I made changes about @standard-schema/spec in #2563. Maybe the merge had an error?

@rdjanuar
Copy link
Collaborator Author

oncheck @benjamincanac

@rdjanuar
Copy link
Collaborator Author

CI check success, we good now @benjamincanac

@benjamincanac benjamincanac merged commit 75c5e87 into v3 Nov 12, 2024
3 checks passed
@benjamincanac benjamincanac deleted the feat/form-apply-transformations branch November 12, 2024 15:43
@benjamincanac
Copy link
Member

Thanks @rdjanuar 😊

@romhml romhml mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romhml romhml romhml approved these changes

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdjanuar @benjamincanac @romhml