-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DropdownMenu/ContextMenu): handle color
field in items
#2510
Conversation
Let me know if you need help for the styles π |
commit: |
@benjamincanac thanks for the offer of help! But I was able to figure out the styles myself.
neutral - item without styles, repeats current behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! I would put the default styles inside the neutral
color to avoid unnecessary merging.
I tried it this way, but if specify defaultVariants: {
size: 'md',
+ color: 'neutral'
} Then it will not be applied since We will have to specify fallback wherever we specify
|
color
propcolor
field in items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add in the tests a color
on one of the items? π
Done π |
Thanks @hywax! π |
π Linked issue
Resolves #2339
β Type of change
π Description
π Checklist