Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(InputMenu/SelectMenu): allow access nested object in option-attribute #2465

Merged
merged 5 commits into from
Oct 30, 2024
Merged

fix(InputMenu/SelectMenu): allow access nested object in option-attribute #2465

merged 5 commits into from
Oct 30, 2024

Conversation

rdjanuar
Copy link
Collaborator

🔗 Linked issue

Resolve #1800

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar changed the title fix(SelectMenu): allow access nested object in option-attribute fix(SelectMenu): allow access nested object in option-attribute Oct 25, 2024
@benjamincanac
Copy link
Member

@rdjanuar Would you mind doing the same thing on the InputMenu for consistency? (can be done in the same PR)

@rdjanuar
Copy link
Collaborator Author

ofc @benjamincanac

@benjamincanac benjamincanac changed the title fix(SelectMenu): allow access nested object in option-attribute fix(InputMenu/SelectMenu): allow access nested object in option-attribute Oct 30, 2024
@benjamincanac benjamincanac merged commit ff18061 into nuxt:dev Oct 30, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

@rdjanuar rdjanuar mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested attributes in objects
2 participants
@rdjanuar @benjamincanac