Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RadioGroup): rendering empty slots #2456

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(RadioGroup): rendering empty slots #2456

merged 1 commit into from
Oct 30, 2024

Conversation

hacknug
Copy link

@hacknug hacknug commented Oct 24, 2024

πŸ”— Linked issue

No issue opened. Easy fix.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

RadioGroup component was missing a conditional to render its nested Radio slots. I also added a test to ensure there are no regressions related to this in the future.

This issue might affect v3 too. I can check and port the changes over there if necessary.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title fix: rendering empty RadioGroup slots fix(RadioGroup): rendering empty slots Oct 29, 2024
@benjamincanac benjamincanac merged commit b6ed1c5 into nuxt:dev Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants