Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): indeterminate checkbox with pagination #2439

Merged
merged 7 commits into from
Oct 24, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Oct 23, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I have an issue in my table using v-model with implementing pagination. On the first page, all items are selected. However, when I move to another page, the indeterminate checkbox does not reset to an unchecked state.

so i fix it feel free to discus

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar
Copy link
Collaborator Author

Hi sorry to bothering you @benjamincanac or @romhml . Same as before can i request an urgent review again? my co working complaint about this issue πŸ˜„

@benjamincanac
Copy link
Member

Would you mind fixing the CI?

@rdjanuar
Copy link
Collaborator Author

done @benjamincanac

@benjamincanac
Copy link
Member

I updated eslint and @nuxt/eslint-config this morning so you might have to fix some issues again 😬

@rdjanuar
Copy link
Collaborator Author

oke no problem @benjamincanac

@rdjanuar
Copy link
Collaborator Author

just asking when will the feature/fix go to main (release) @benjamincanac ?

@benjamincanac benjamincanac merged commit 070d2f8 into nuxt:dev Oct 24, 2024
2 checks passed
@benjamincanac
Copy link
Member

benjamincanac commented Oct 24, 2024

Will try to make a patch release this week! You can use the Edge package in the meantime 😊

@rdjanuar
Copy link
Collaborator Author

Okay, thank you for the review and sorry to bother you again, @benjamincanac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants