Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Progress): pass down attrs to <progress> to improve accessibility #1881

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

noook
Copy link
Collaborator

@noook noook commented Jun 14, 2024

πŸ”— Linked issue

NA

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In an effort to improve the accessibility of our attributes, it would be more relevant to pass down the attributes from the root element to the <progress> element itself.

I also assigned aria-valuemax and aria-valuenow as they can be pre-filled. This opens the door for the user to provide other attributes such as aria-valuetext freely.

Note that there is a small breaking change as attributes are moved.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title feat(Progress): pass down attributes to <progress> fix(Progress): pass down attributes to <progress> to improve accessibility Jun 24, 2024
@benjamincanac benjamincanac changed the title fix(Progress): pass down attributes to <progress> to improve accessibility fix(Progress): pass down attrs to <progress> to improve accessibility Jun 24, 2024
@benjamincanac benjamincanac merged commit abd13f1 into nuxt:dev Jun 24, 2024
2 checks passed
binhtranhuu pushed a commit to binhtranhuu/nuxt-ui that referenced this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants