fix(Progress): pass down attrs to <progress>
to improve accessibility
#1881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
NA
β Type of change
π Description
In an effort to improve the accessibility of our attributes, it would be more relevant to pass down the attributes from the root element to the
<progress>
element itself.I also assigned
aria-valuemax
andaria-valuenow
as they can be pre-filled. This opens the door for the user to provide other attributes such asaria-valuetext
freely.Note that there is a small breaking change as attributes are moved.
π Checklist