Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb divider icons don't work when icons are dynamic #1687

Closed
kevinstory opened this issue Apr 18, 2024 · 1 comment · Fixed by #1789
Closed

Breadcrumb divider icons don't work when icons are dynamic #1687

kevinstory opened this issue Apr 18, 2024 · 1 comment · Fixed by #1789
Labels
bug Something isn't working

Comments

@kevinstory
Copy link

kevinstory commented Apr 18, 2024

Environment

  • Operating System: Linux
  • Node Version: v18.16.0
  • Nuxt Version: 3.11.2
  • CLI Version: 3.11.1
  • Nitro Version: 2.9.6

Version

v3.10.1 (stackblitz)

Reproduction

https://stackblitz.com/edit/github-mcijue

Description

When using the default divider icons in a breadcrumb, while icons are set to dynamic in the app.config, the icons will not render but instead output the text of the icon. See example reproduction.

Additional context

No response

Logs

No response

@kevinstory kevinstory added the bug Something isn't working label Apr 18, 2024
@kevinstory
Copy link
Author

Looks like I was able to fix this by updating the icon element on line 2:

<span v-if="dynamic" :class="name" />

instead of

<Icon v-if="dynamic" :name="name" />

I would love to do a PR if possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant