-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module): add option to disable global css styles #1266
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Wouldn't it be easier to simply override the |
You could override it but you cannot "unset" it. I'd prefer to keep the browser default rather than providing a custom style. As for the select component, I didn't notice a difference. However, wouldn't it be better to include the style in the SFC? |
And regarding the link outlines, in my opinion, they are similar to the |
You're right about the |
Would you mind adding the option to the docs here: https://github.com/nuxt/ui/blob/dev/docs/content/1.getting-started/2.installation.md#options instead of the theming page? |
Maybe It's also worth adding the content of |
Good point with the link to the file. I added it. |
π Linked issue
β Type of change
π Description
This pull request introduces an option to disable the global CSS styles injected by the module. The primary motivation for this feature is the
::selection
style, which can be quite intrusive on some websites. However, upon considering whether to allow disabling only this specific option, I concluded that it would be more practical to allow the disabling of all styles.I am of course open to suggestions. π
π Checklist