Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vue and fix type issues #1112

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: update vue and fix type issues #1112

merged 2 commits into from
Dec 19, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Caught by ecosystem CI, there are some type issues within nuxt/ui that will be revealed in next vue release. This bumps vue version and addresses them.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Dec 16, 2023
@danielroe danielroe self-assigned this Dec 16, 2023
Copy link

vercel bot commented Dec 16, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Dec 16, 2023 9:14pm

@@ -104,7 +104,8 @@ export default defineComponent({
return props.state
}

async function onSubmit (event: SubmitEvent) {
async function onSubmit (payload: Event) {
const event = payload as SubmitEvent
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add some validation here.

@benjamincanac benjamincanac merged commit 5c99ae1 into dev Dec 19, 2023
2 checks passed
@benjamincanac benjamincanac deleted the chore/vue-3.3.11 branch December 19, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants