Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abortNavigation without err argument passed doesn't abort navigation with ssr disabled #14154

Closed
kvcvc opened this issue Jun 15, 2022 · 0 comments · Fixed by nuxt/framework#6857
Closed

abortNavigation without err argument passed doesn't abort navigation with ssr disabled #14154

kvcvc opened this issue Jun 15, 2022 · 0 comments · Fixed by nuxt/framework#6857
Assignees
@danielroe
Labels
3.x bug 🔨 p3-minor

Comments

@kvcvc
Copy link

kvcvc commented Jun 15, 2022

Environment

  • Operating System: Linux
  • Node Version: v16.15.0
  • Nuxt Version: 3.0.0-rc.3
  • Package Manager: [email protected]
  • Builder: vite
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

  1. Use the pages folder
  2. Define middleware in page metadata
  3. Return abortNavigation() from middleware
  4. Disable ssr in nuxt.config.ts

Describe the bug

With ssr being disabled and no argument passed to abortNavigation(), navigation doesn't abort

Additional context

codesandbox

Logs

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(nuxt): throw hard error on initial spa load if aborted nuxt/framework
2 participants
@danielroe @kvcvc