Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable document driven with route meta #1333

Merged
merged 5 commits into from
Jul 6, 2022
Merged

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Jul 5, 2022

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Allow disabling/modifying document-driven

<script setup>
definePageMeta({
  documentDriven: false,
  // Or if need content but no surround
  documentDriven: {
    page: true,
    surround: false,
  },
});
</script>

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for nuxt-content ready!

Name Link
🔨 Latest commit 0499253
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/62c57911045b530009883f98
😎 Deploy Preview https://deploy-preview-1333--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz requested review from atinux and Tahul July 5, 2022 12:28
@atinux
Copy link
Member

atinux commented Jul 5, 2022

Looking great thank you!

Can you update the documentation on https://content.nuxtjs.org/guide/writing/document-driven to add a "Disable or control the page data" section before the "Example" section?

Copy link

@hacknug hacknug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo

docs/content/3.guide/1.writing/7.document-driven.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Tahul Tahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@atinux atinux merged commit d5d23c9 into main Jul 6, 2022
@atinux atinux deleted the feat/document-driven-meta branch July 6, 2022 12:24
@farnabaz farnabaz mentioned this pull request Aug 12, 2022
farnabaz added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: Sébastien Chopin <[email protected]>
Co-authored-by: Yaël Guilloux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants