Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content): use defu.arrayFn instead of custom merger #408

Merged
merged 1 commit into from
Aug 25, 2020
Merged

fix(content): use defu.arrayFn instead of custom merger #408

merged 1 commit into from
Aug 25, 2020

Conversation

benjamincanac
Copy link
Member

Use defu.arrayFn to merge options

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@benjamincanac benjamincanac requested a review from atinux August 24, 2020 16:22
@benjamincanac benjamincanac linked an issue Aug 24, 2020 that may be closed by this pull request
Config merging broken if array #399
Closed
@benjamincanac benjamincanac mentioned this pull request Aug 24, 2020
Closed
@benjamincanac benjamincanac marked this pull request as ready for review August 25, 2020 08:55
@benjamincanac benjamincanac merged commit 9e5ba55 into dev Aug 25, 2020
@benjamincanac benjamincanac deleted the fix/merge-config branch August 25, 2020 09:28
@benjamincanac benjamincanac linked an issue Aug 25, 2020 that may be closed by this pull request
Cannot remove default plugins #377
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config merging broken if array Cannot remove default plugins
2 participants
@benjamincanac @atinux