Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content.nuxtjs.org: Social Icons size too big (docs) #1419

Closed
luisoos opened this issue Aug 5, 2022 · 4 comments · Fixed by #1424
Closed

content.nuxtjs.org: Social Icons size too big (docs) #1419

luisoos opened this issue Aug 5, 2022 · 4 comments · Fixed by #1424

Comments

@luisoos
Copy link

luisoos commented Aug 5, 2022

Environment

Browser

Reproduction

Just get on any page at Nuxt Content Documentation and scroll down to the footer.

Describe the bug

The logos of Nuxt and Vue Telescope are too big. This not only doesn't look good, but also causes that you can't enter specific links and text is hidden.
grafik

Additional context

I think this is a problem with Docus, but because it's not open-sourced yet, I thought it might be the right option to open an Issue here, since the documentation is here as well. I am sorry if that was a wrong idea.

Logs

No response

@nobkd
Copy link
Contributor

nobkd commented Aug 6, 2022

You're right, but it's only on the get-started page, that the icons cover some text.

On other pages the color of the icons is more of a problem, because they use the same color as the surround-links

without hover on icon:
Screenshot_20220806_015727

with hover on icon:
Screenshot_20220806_015900

@farnabaz farnabaz mentioned this issue Aug 8, 2022
7 tasks
@nobkd
Copy link
Contributor

nobkd commented Aug 22, 2022

This is still an issue, isn't it?

@nozomuikuta
Copy link
Collaborator

@nobkd

I don't see the too-big logos in Get Started page. 🤔
You might want to hard-refresh the page and/or delete browser caches.

@nobkd
Copy link
Contributor

nobkd commented Aug 22, 2022

Soo... I looked into it again.

It seems like Firefox on desktop handles svg sizes different than Chromium or other browsers or Firefox on mobile devices.
Chromium scales them to 0 × 0 (width × height) and Firefox on desktop uses the maximal size, I suppose.

I also found out, that the class="w-5 h-5" is missing for NuxtJS and Vue Telescope social icons for the svg tag like they are defined for Twitter and GitHub social icon svg tags

Also the view boxes for the Vue Telescope and NuxtJS social icon svgs are not optimal, because they look smaller than Github and Twitter icons
when sized with the same classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants