Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentDriven configuration #1345

Closed
Tahul opened this issue Jul 11, 2022 — with Volta.net · 2 comments · Fixed by #1378
Closed

Better documentDriven configuration #1345

Tahul opened this issue Jul 11, 2022 — with Volta.net · 2 comments · Fixed by #1378
Labels
enhancement New feature or request

Comments

Copy link
Contributor

Tahul commented Jul 11, 2022

Following this issue:
nuxt/nuxt.com#798

What is Expected?

In addition to being able to toggle documentDriven feature scopes via definePageMeta, I think we should also handle string parameters as this:

definePageMeta({
   page: '/my-page-path',
   surround: '/my-surround-path'
})

What is actually happening?

We can only toggle the feature with booleans.

@Tahul Tahul added bug Something isn't working and removed bug Something isn't working labels Jul 11, 2022 — with Volta.net
@atinux atinux added the enhancement New feature or request label Jul 11, 2022
@atinux
Copy link
Member

atinux commented Jul 11, 2022

What about supporting the QueryBuilder object as well?

Copy link
Contributor Author

Tahul commented Jul 11, 2022

Let's do both! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants