Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exclusive navigation behavior #394

Closed
farnabaz opened this issue Jun 9, 2021 — with Volta.net · 2 comments · Fixed by #395
Closed

Fix exclusive navigation behavior #394

farnabaz opened this issue Jun 9, 2021 — with Volta.net · 2 comments · Fixed by #395
Labels
enhancement New feature or request

Comments

Copy link
Collaborator

farnabaz commented Jun 9, 2021

Assume

/foo
-- /bar -> exclusive
-- -- bar-content.md
-- -- /baz
-- -- -- baz-content.md

When user visits the /foo/bar/baz/baz-content we should show navigation list of /foo/bar because its exclusive and user visits one of its descendants
(Currently it should navigation list of /foo)

On the other hands we may need a back link on top on aside navigation to redirect user to parent navigation and make other sections of website navigable using aside navigations

@farnabaz farnabaz added the enhancement New feature or request label Jun 9, 2021 — with Volta.net
Copy link
Contributor

atinux commented Jun 9, 2021

Indeed, we need to define the levels of both Header and Aside navigations.

I think the Header should handle top level navigation (depending if it has children I believe), where the Aside is used for the current parent.

What do you have in mind to specify /bar as exclusive? Using a prop in the frontmatter of /bar/index.md?

Copy link
Collaborator Author

farnabaz commented Jun 9, 2021

I think the Header should handle top level navigation (depending if it has children I believe), where the Aside is used for the current parent.

There is a helper that can be used to retrieve top level navigation

What do you have in mind to specify /bar as exclusive? Using a prop in the frontmatter of /bar/index.md?

Exactly, we have navigation.exclusive in the frontmatter data that do the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants