Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update prose components styling #358

Closed
Tahul opened this issue May 31, 2021 · 0 comments · Fixed by #505
Closed

chore: update prose components styling #358

Tahul opened this issue May 31, 2021 · 0 comments · Fixed by #505
Labels
enhancement New feature or request

Comments

@Tahul
Copy link
Contributor

Tahul commented May 31, 2021

Prose components styling isn't following theming as it is using raw CSS values in lots of places.

I think this could be the subject of a refactor, to stick with our theming values and so ensure consistency across design.

I don't see any problem with using @apply for that task.

As an addition, I think we could move those components into a subfolder (atoms/prose ?) and add the prefix via @nuxt/components config.

Ideally, I think this should be a module in itself too, not be bundled with our defaultTheme directly.

Maybe we could think of a way to share these in the long run, allowing features like distributing Prose styling set for your app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants