Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define theme settings #244

Closed
Tahul opened this issue Apr 9, 2021 · 3 comments
Closed

feat: define theme settings #244

Tahul opened this issue Apr 9, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Tahul
Copy link
Contributor

Tahul commented Apr 9, 2021

We need to define what theme settings we want.

  • Colors
  • Fonts
  • Sizes (fonts, padding, margins, containers)
  • Shadows
  • Blurs
@Tahul Tahul added the enhancement New feature or request label Apr 9, 2021
@Tahul Tahul changed the title Define theme settings feat: define theme settings May 3, 2021
Copy link
Contributor Author

Tahul commented May 3, 2021

Now that we have theme settings, including color injection, we should take advantage of this and help users to avoid using the Windi config to update things that are related to our default theme.

This feature is definitely implementable now.

Copy link
Contributor Author

Tahul commented May 3, 2021

Related to #273

Copy link
Contributor Author

Tahul commented May 3, 2021

Maybe we should consider defining Windi shortcuts used in the app from docus.config.ts (this is feasible using the module-level injection).

Also I think shortcut names should be self-explanatory, and not using prefixes, so it looks okay in the config tree.

Current shortcuts can so be moved into defaultTheme/settings.ts as defaults.

@Tahul Tahul self-assigned this May 4, 2021
@Tahul Tahul closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant