Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): Nuxt 2 support #508

Merged
merged 3 commits into from
Jul 25, 2022
Merged

fix(module): Nuxt 2 support #508

merged 3 commits into from
Jul 25, 2022

Conversation

Tahul
Copy link
Contributor

@Tahul Tahul commented Jul 15, 2022

Since 5.2.0, some Nuxt 2 users encountered issues with the module.

@bmulholland kindly found it was related to @nuxt/kit inconsistencies between Nuxt 2 and 3.

That PR solves the support for tailwind.config in Nuxt 2, and disables the config viewer in that environment.

Config viewer seem to break the stack as @nuxt/kit addServerHandler seem to break the module in that environment.

That issue is tracked here, thanks to @harlan-zw: #507

Resolves: #500

@bmulholland
Copy link

Thanks for the fix <3

@Tahul
Copy link
Contributor Author

Tahul commented Jul 15, 2022

Hey @bmulholland ;

If you want to use the fix in your app, I made an edge publish for it:
@nuxtjs/[email protected]

Thanks for your collaboration and sorry for not checking Nuxt 2 support earlier, it was unexpected!

@bmulholland
Copy link

Hah! I bet it was unexpected :). A bug in a core nuxt library caused by an ambiguous, undocumented configuration parameter that changed between versions also by the core library is one hell of a gotcha.

@harlan-zw
Copy link
Contributor

Looks good 👍 The Nuxt 2 playground will be useful to avoid regressions in the future

@dneckel
Copy link

dneckel commented Jul 22, 2022

Would love to see this merged soon ❤️

@pencilcheck
Copy link

pencilcheck commented Oct 7, 2022

Not sure if this is related, but I am also getting this error when I tried to add it as a module inside my builder class but for my case it seems like downgrading didn't fix this issue

#505

nuxt/nuxt#10247

Further investigation shows that nuxt-highlightjs somehow add the css array an object instead of a string, and that cause the resolvePath function to fail, not sure if this is a error from the tailwindcss side, or is it an error in nuxt-highlightjs side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major 5.2.0 regression: no longer loads tailwind config by default
6 participants