-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not delete name of route with children #116
Comments
This issue as been imported as question since it does not respect nuxt-i18n issue template. Only bug reports and feature requests stays open to reduce maintainers workload. |
Hi @bartlomieju |
Hi @paulgv sorry for trouble, it looks like my Nuxt route config is improper, I should have added |
@bartlomieju no worries! I was wondering why you didn't have that |
This question has been resolved by @bartlomieju, see answer. |
Hi @paulgv and @bartlomieju I have the same error, I open a question: #286 I have the index.vue but it doesn't work for me, it also deletes. Please, any help to resolve this? |
@paulgv @bartlomieju I think this is breaking a valid use case because the assumption that routes with children should not have a name is incorrect. Navigating to a route which has children is valid and so those routes should be allowed a name. I have a structure like this which works fine when I remove the deletion. |
I don't immediately see (not sure if I ever knew), why names are removed. Maybe you want to create new issue about that? But I'm not sure that structure that you've shown is entirely correct. For example, I can't see how to trigger |
@rchl I will create a new issue for it. The structure works as-is and creates the correct routes. The |
Hi!
Today I stumbled across a problem that deletes name of routes that have children. I think this is unexpected behaviour, as I tend to have directory structure like this:
and do a redirect in
vendors/_slug.vue
file.The culprit is this line:
https://github.com/nuxt-community/nuxt-i18n/blob/45ff90d1b8076c12f5c1a75fb7e2d398450e7c51/src/helpers/routes.js#L70
What is your opinion on this one?
The text was updated successfully, but these errors were encountered: