Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import runtime types from @nuxthub/core #168

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix: import runtime types from @nuxthub/core #168

merged 1 commit into from
Jun 14, 2024

Conversation

danielroe
Copy link
Contributor

resolves #166
closes #167

@farnabaz
Copy link
Collaborator

Do you think we should use this pattern in all modules? Because other modules will face the same issue with module builder,
Like image module https://github.com/nuxt/image/blob/e7242fbc2bb37d484f1c903e8a28532973b11ddb/src/runtime/utils/meta.ts#L1-L3

@Barbapapazes Barbapapazes mentioned this pull request Jun 14, 2024
Open
4 tasks
@danielroe
Copy link
Contributor Author

Indeed, we should.

@atinux atinux merged commit 4ff9609 into main Jun 14, 2024
4 checks passed
@danielroe danielroe deleted the fix/runtime-type-imports branch June 14, 2024 09:37
@danielroe
Copy link
Contributor Author

@farnabaz Nice spot. That is actually already broken, even with v0.6.0 of the module builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The type inferences for hubDatabase and hubKV methods are gone
3 participants
@danielroe @farnabaz @atinux