fix!: use regexps to match dependency externals (#213)

* avoids inlining subpaths or fully resolved paths

src/core/build/rollup.spec.ts

@@ -2,7 +2,7 @@ import { resolve } from 'upath'
 
 import { Package } from '../package'
 import { builtins, builtinsMap } from './builtins'
-import { getRollupConfig } from './rollup'
+import { getRollupConfig, regexpForPackage } from './rollup'
 import { getNameFunction } from './utils'
 
 const getFixturePath = (path: string) =>
@@ -68,3 +68,29 @@ describe('builtins', () => {
     expect(Object.values(map)[0]).toBe(true)
   })
 })
+
+describe('external matching', () => {
+  const pattern = regexpForPackage('@nuxt/utils')
+
+  it('should match package name', () => {
+    expect(pattern.test('@nuxt/utils')).toBeTruthy()
+  })
+
+  it('should match package subpath', () => {
+    expect(pattern.test('@nuxt/utils/subpath')).toBeTruthy()
+  })
+
+  it('should match fully resolved package path', () => {
+    expect(
+      pattern.test('/project/node_modules/@nuxt/utils/index.js')
+    ).toBeTruthy()
+    expect(
+      pattern.test('c:\\project\\node_modules\\@nuxt\\utils\\index.js')
+    ).toBeTruthy()
+  })
+
+  it('should not match substring paths', () => {
+    expect(pattern.test('@nuxt/utils2')).toBeFalsy()
+    expect(pattern.test('a@nuxt/utils')).toBeFalsy()
+  })
+})

src/core/build/rollup.ts

@@ -40,6 +40,17 @@ export interface BuildOverride {
   format: OutputOptions['format']
 }
 
+export function regexpForPackage(name: string) {
+  // Should match `@foo/bar/index.js`, `node_modules\@foo\bar`,
+  // `node_modules/@foo/bar` as well as `@foo/bar`.
+  name = name.replace(/[\\/]/g, '[\\\\/]')
+  return new RegExp(`(^|node_modules[\\\\/])${name}([\\\\/]|$)`, 'i')
+}
+
+function regexpForPackages(packages?: Record<string, string>) {
+  return Object.keys(packages || {}).map(regexpForPackage)
+}
+
 export function getRollupConfig(
   {
     input,
@@ -74,9 +85,9 @@ export function getRollupConfig(
 
   const external = [
     // Dependencies that will be installed alongside the package
-    ...Object.keys(pkgConfig.dependencies || {}),
-    ...Object.keys(pkgConfig.optionalDependencies || {}),
-    ...Object.keys(pkgConfig.peerDependencies || {}),
+    ...regexpForPackages(pkgConfig.dependencies),
+    ...regexpForPackages(pkgConfig.optionalDependencies),
+    ...regexpForPackages(pkgConfig.peerDependencies),
     // Builtin node modules
     ...builtins,
     ...externals,