Skip to content

Commit

Permalink
feat: allow specifying esbuild plugin options directly
Browse files Browse the repository at this point in the history
  • Loading branch information
danielroe committed Sep 30, 2020
1 parent 19939be commit 0125825
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 16 deletions.
10 changes: 10 additions & 0 deletions siroc.config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"rollup": {
"replace": {
"process.env.TIME": "false"
},
"esbuildOptions": {
"target": "es2015"
}
}
}
15 changes: 0 additions & 15 deletions siroc.config.ts

This file was deleted.

5 changes: 4 additions & 1 deletion src/core/build/rollup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import nodeResolvePlugin, {
import defu from 'defu'
import type { RollupOptions, OutputOptions } from 'rollup'
import dts from 'rollup-plugin-dts'
import esbuild from 'rollup-plugin-esbuild'
import esbuild, { Options as EsbuildOptions } from 'rollup-plugin-esbuild'

import { Package } from '../package'
import { includeDefinedProperties, includeIf } from '../utils'
Expand All @@ -30,6 +30,7 @@ export interface BuildConfigOptions extends RollupOptions {
externals?: (string | RegExp)[]
resolve?: RollupNodeResolveOptions
input?: string
esbuildOptions?: EsbuildOptions
}

export function getRollupConfig(
Expand All @@ -44,6 +45,7 @@ export function getRollupConfig(
preferBuiltins: true,
},
plugins = [],
esbuildOptions,
...options
}: BuildConfigOptions,
{
Expand Down Expand Up @@ -87,6 +89,7 @@ export function getRollupConfig(
commonjsPlugin({ include: /node_modules/ }),
esbuild({
target: 'es2018',
...esbuildOptions,
}),
jsonPlugin(),
].concat(plugins)
Expand Down

0 comments on commit 0125825

Please sign in to comment.