Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuxt-i18n types (refering #132) #133

Merged
merged 1 commit into from
Oct 6, 2018
Merged

nuxt-i18n types (refering #132) #133

merged 1 commit into from
Oct 6, 2018

Conversation

kevinmarrec
Copy link

Fixes #132

@paulgv
Copy link
Collaborator

paulgv commented Oct 6, 2018

Thank you @kevinmarrec

@paulgv paulgv merged commit 817c58e into nuxt-modules:master Oct 6, 2018
@kevinmarrec kevinmarrec mentioned this pull request Oct 10, 2018
Merged
@kevinmarrec
Copy link
Author

kevinmarrec commented Nov 12, 2018 •
edited
Loading

@paulgv I'm working on nuxt/nuxt#4164 since few weeks, and on the way I figured out I've some improvements to do around nuxt-i18n regarding what I've already done through this PR.

  1. TypeScript Convention (it's just about dobule quotes and some semi-colons)
  2. Add tests (There will be tests regarding types around nuxt, so having typing tests around here should be nice too)

So I'll open a new issue and PR soon

EDIT : PR is here : #156

@kevinmarrec kevinmarrec deleted the typings branch November 18, 2018 14:34
@kevinmarrec kevinmarrec mentioned this pull request Nov 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinmarrec @paulgv