Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

fix: use middleware for vite registration #479

Closed
wants to merge 8 commits into from

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 11, 2021

cc: @pi0

@pi0
Copy link
Member

pi0 commented May 12, 2021

@danielroe Was try on injecting the register method unsuccesfull?

danielroe added a commit that referenced this pull request May 17, 2021
* addresses issue with .mjs format (nuxt + jest)
* uses `require.resolve` to locate templates
* compile composables into single file
* reverts 16e21eb (#470)
* retains auto-registration for testing (in cjs export - if `process.env.NODE_ENV === 'test'`)

closes #476, closes #479 (by implementing), closes nuxt/vite#134, closes nuxt/vite#123
danielroe added a commit that referenced this pull request May 21, 2021
* addresses issue with .mjs format (nuxt + jest)
* compile composables into single file
* registers composition API using webpack entrypoint (or, for vite, by overriding `./middleware.js` import)
* retains auto-registration for testing (in cjs export - if `process.env.NODE_ENV === 'test'`)

closes #476, closes #479 (by implementing)

Also should cover nuxt/vite#134 and nuxt/vite#123.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants