feat: add composition api helper to interact with `head()` #35

mathe42 · 2020-05-07T10:19:47Z

No description provided.

danielroe

I love it. I do wonder if it would be better to rename getMeta to useMeta and the overall function could be useHead?

Also might be worth a couple of lines in meta-test-d.ts just confirming the expected types?

README.md

test/fixture/pages/meta.vue

Co-authored-by: Daniel Roe <[email protected]>

mathe42 · 2020-05-07T15:45:30Z

@danielroe I changed the names as you suggested. 👍

src/index.ts

Co-authored-by: Daniel Roe <[email protected]>

src/meta.ts

feat(meta): added useMeta

869f8d9

danielroe suggested changes May 7, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

test/fixture/pages/meta.vue Outdated Show resolved Hide resolved

danielroe assigned mathe42 May 7, 2020

danielroe changed the title ~~feat(meta): added useMeta~~ feat: add composition api helper to interact with head() May 7, 2020

Apply suggestions from code review

36fa3b1

Co-authored-by: Daniel Roe <[email protected]>

danielroe added the enhancement New feature or request label May 7, 2020

feat(usehead): rename functions

60a803f

danielroe reviewed May 7, 2020

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

Update src/index.ts

955d43b

Co-authored-by: Daniel Roe <[email protected]>

danielroe reviewed May 7, 2020

View reviewed changes

src/meta.ts Outdated Show resolved Hide resolved

fix: remove type import (for the benefit of tsd)

b553c22

danielroe merged commit b7467e2 into nuxt-community:master May 7, 2020

mathe42 deleted the useMeta branch May 7, 2020 20:56

Provide feedback