-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve storage #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Really like that you removed the use of isUnset, and introduced dedicated removers instead. I have a few questions.
Codecov Report
@@ Coverage Diff @@
## dev #360 +/- ##
===================================
Coverage 100% 100%
===================================
Files 1 1
Lines 2 2
===================================
Hits 2 2 Continue to review full report at Codecov.
|
This PR has been published in v4.6.0 |
universal-storage is using a forked and enhanced version of auth-module's storage. Main improvements:
fixes #332, fixes #326, fixes #134.
Huge thanks to @MathiasCiarlo for discovery, review and #333