Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve storage #360

Merged
merged 8 commits into from
May 30, 2019
Merged

feat: improve storage #360

merged 8 commits into from
May 30, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 24, 2019

universal-storage is using a forked and enhanced version of auth-module's storage. Main improvements:

  • Universal cookies support
  • Auto object and primitives serialization and deserialization
  • Heavily tested on alibaba.aero

fixes #332, fixes #326, fixes #134.

Huge thanks to @MathiasCiarlo for discovery, review and #333

Copy link
Collaborator

@MathiasCiarlo MathiasCiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Really like that you removed the use of isUnset, and introduced dedicated removers instead. I have a few questions.

lib/core/utilities.js Outdated Show resolved Hide resolved
lib/core/storage.js Outdated Show resolved Hide resolved
@pi0 pi0 added the WIP label May 25, 2019
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #360 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #360   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68c4eb...e99865f. Read the comment docs.

@pi0 pi0 merged commit d05fcca into dev May 30, 2019
@pi0 pi0 deleted the feat/improve-storage branch May 30, 2019 19:52
@pi0 pi0 mentioned this pull request May 30, 2019
@pi0 pi0 removed the WIP label May 30, 2019
@pi0
Copy link
Member Author

pi0 commented May 30, 2019

This PR has been published in v4.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants