Skip to content

Commit

Permalink
chore(ci): Only download required build artifacts for Windows
Browse files Browse the repository at this point in the history
Our Windows CI has a separate build job with the sole purpose of
creating an installer, by joining three different Windows builds:

- Qt5: x86 and x86_64
- Qt6: x86_64

To accomplish that, this job needs to download these build artifacts
from previous jobs.

Until now, we would download all build artifacts, including ones from
unrelated jobs such as Linux and macOS, which doesn't make sense, as
it's wasteful and slow.

Thankfully, version 4.1.0[1] of 'actions/download-artifact' now allows
us to specify which artifacts to download, which is what this commit
does.

[1] https://github.com/actions/download-artifact/releases/tag/v4.1.0
  • Loading branch information
guihkx committed Dec 21, 2023
1 parent fd013cc commit ddb85cb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,10 @@ jobs:
uses: actions/checkout@v3

- name: Download build artifacts from previous job
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: artifacts
pattern: '*Windows*'

- name: Ensure a 64-bit Qt 6 build is present
run: |
Expand Down

0 comments on commit ddb85cb

Please sign in to comment.