Handle overlay subnet case while filtering subnets in vms based on cluster #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimutant
approved these changes
Sep 28, 2022
premkarat
pushed a commit
that referenced
this pull request
Sep 30, 2022
* feat/inventory_issue#232 (#233) * Add examples for images and static routes(#267) * Add mac address for vm creation (#272) * Update ntnx_vms.py Add the ability to optionally set MAC Address for a network interface * Update vms.py Add optional mac_address definition to _build_spec_networks * fix spec * sanity fix Co-authored-by: Ken Moini <[email protected]> * fix iass example Imprv/issue#250 (#268) * add var to iass example * iaas task to create static routes * fix vars * sanity fix * iaas fixes * Minor changes Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1> Co-authored-by: Pradeepsingh Bhati <[email protected]> * Consider cluster reference as well for getting subnet uuid (#266) * Consider cluster as well for getting subnet uuid * Fix incase of update * Bug/inventory#228 new (#278) Fix for fetching all vms when length > 500 Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1> Co-authored-by: Pradeepsingh Bhati <[email protected]> * Bug/docs readme fixes (#280) * Doc fixes * Cluster name not usage warning * Enable role mappings and new user / user groups creation in ntnx_projects (#281) * Use of projects interna and custom acp creation * Add module utils changes for projects internal * projects internal user and user groups fixes * Minor user group ref fix * condition fix * Project scope in acp fix and create workflow fix * Add projects acp update and idempotency scenarios * Update projects info module to include acps * sanity fix * Add account references in projects * Add vpc related config in projects spec * Update project tests to include vpcs, tunnels and accounts * Minor fixes and test automation for projects internal based scenarios * Sanity fixes * Minor constants name change Co-authored-by: alaa-bish <[email protected]> * Enable PC tests * formatting * Isort fix * Minor subnet fix * Cluster filters using name fix * sanity fixes * Minor read me changes * Handle overlay subnet case while filtering subnets in vms based on cluster (#286) * handle overlay subnet case * Minor fixes and tests addition * Minor tests and sanity fixes * Remove clusters pagination as API doesn't support * Skippin cluster test due to tech issue * Make address groups tests names unique * Minor test fixes * Test fix * Adding free uuids * Minor fixes * Minor fixes for system roles * Add examples and doc update * Minor example update * Minor readme fix * Examples dependency * Release based readme change * 1.7.0 read me update * read me update * changelog changes * changelog changes * minor doc change * projects docs fix Co-authored-by: Andreas Hubert <[email protected]> Co-authored-by: alaa-bish <[email protected]> Co-authored-by: Ken Moini <[email protected]> Co-authored-by: Gevorg Khachatryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix provider by #266 only deals with vlan subnets.
Incase of overlay subnets we cannot filter based on cluster reference of vm. So added new field in subnet spec in vm networks to provide cluster instead of picking from vm cluster reference. This will enable user to pass cluster reference in subnet when required.