Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image placement policy module and its info module #214

Merged
merged 15 commits into from
Jun 30, 2022

Conversation

bhati-pradeep
Copy link
Collaborator

New modules:

  • ntnx_image_placement_policy
  • ntnx_image_placement_policies_info

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Jun 16, 2022

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/2507799365

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Jun 16, 2022

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/2507845824

@bhati-pradeep bhati-pradeep force-pushed the feat/issue-8-image-placement-module branch from 29e538a to fc14cab Compare June 22, 2022 10:35
@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Jun 23, 2022

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/2547341454

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Jun 23, 2022

/ok-to-test

Integration test run status is : success
Converage is : 84 %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/2547438069

README.md Outdated
@@ -110,6 +110,8 @@ ansible-playbook examples/iaas/iaas.yml
| ntnx_floating_ips_info | List existing Floating_Ips. |
| ntnx_pbrs | Create or delete a PBR. |
| ntnx_pbrs_info | List existing PBRs. |
| ntnx_image_placement_policy | Create, update or delete a image placement policy. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you order them in ascending name order

result["response"] = resp


def get_particular_policies(module, result):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use word specific instead of particular

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be get_all_policies()

@bhati-pradeep bhati-pradeep force-pushed the feat/issue-8-image-placement-module branch from bafacdc to d81c4b6 Compare June 30, 2022 10:22
@bhati-pradeep bhati-pradeep merged commit 67359b3 into feat/1.3 Jun 30, 2022
premkarat pushed a commit that referenced this pull request Jul 4, 2022
* security rules basic structure #207

* security rules spec

* security rules create and delete functionality

* Fix sanity and doc

* security rules update functionality

* security rules info module

* add integraioson test

* security rules spec fixes

* security rules spec fixes

* security rules spec fixes

* security rules spec fixes, rule update functionality

* security rules requirements fixes

* fix sanity

* security rules requirements and spec generation fixes

* security rules requirements and spec generation fixes

* Add integration test

* sanity fix

* Add integration tests

* security rules requirements and spec generation fixes

* sanity fix

* Add integration test

* ad_rule -> vdi_rule

* update protocols spec, ability to delete rule

* update protocols spec

* updates for protocols spec

* updates for protocols spec

* Fix integration test

* updates for isolation rule

* updates for app, ad quarantine rules

* fix integraton

* Nutanix Image Module (#211)

* Image ansible module for creating images in PC

* Image placement policy module and its info module  (#214)

* Image placement policy module

* Add functionality to deattach all the categories from vm using flag remove_categories (#216)

* Add functionality to remove all categories from vm

* Update docs

* Vm example minor fix

* list functionality for address/service groups

* black and isort fixes

* black and isort fixes

* black and isort fixes

* black and isort fixes

* update requirements

* fixes

* ADGroup fixes

* ADGroup fixes

* remove default values for fields which are updatable

* Doc fix

* allow all updates

* allow all updates

* Common spec for categories mapping

* Formatting

* Formatting changes

* formatting

* formatting

* flake8 changes

* Sanity fix

* config changes

* Update categories in tests

* categories mapping

* categories mapping optimizations

* default_internal_policy fixes

* default_internal_policy fixes

* fixes for target categories updating

* Fix tests

* fixes for rules description

* remove categories mapping and prject reference

* Fix tests

* fix integration

* flake8 fix

* black and isort fixes

* black and isort fixes

* examples fixes

* isolation rule docs fixes

* fix sanity

* galaxy file changes

* sanity fix

* docs fixes

* vm's create ova and clone example fixes

* fix sanity

* fix sanity

* doc fixes

* doc fixes

* Setup config changes

* fix test

* Security info module fix

* doc fix

* Lint fixes

* setup config changes

* quarantine rule uuid changes

* sanity fix

* Update and info module for static routes  (#221)

Static routes module and info module

* UUID changes

* Changes for sanity and config

* sanity fix

* static routes minor formatting

* setup config changes

* formatting

* Fix bug dynamic inventory bug due to load_params

* changelog and readme updates

* Docs changes

* Change log changes

* Update docs

* Docs update

* Minor fix

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>
Co-authored-by: alaa-bish <[email protected]>
Co-authored-by: Gevorg Khachatryan <[email protected]>
Co-authored-by: Yannick Struyf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants