Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] error in sample karbon/create_k8s_cluster.yml #349

Closed
Golgautier opened this issue Apr 5, 2023 · 0 comments · Fixed by #357
Closed

[Bug] error in sample karbon/create_k8s_cluster.yml #349

Golgautier opened this issue Apr 5, 2023 · 0 comments · Fixed by #357
Assignees
Labels
bug Something isn't working

Comments

@Golgautier
Copy link

Golgautier commented Apr 5, 2023

Describe the bug
create_k8s_cluster.yml seems to have an issue.
In the set-fact task, we do setup

storage_class:
    name: <container_name>

First, It seems strange to set container name in the storage-class variable.

In the cluster deployment code :

  • Dev clusters use : storage_container: "{{storage_class.name}}" : it is ok (but not clear/clean)
  • Prod cluster uses : storage_container: "{{storage_container.name}}" : it fails because of variable storage_container is not defined

To Reproduce
Just try to deploy prod cluster from sample.

Stack trace

Expected behavior
I htink it would be great to replace

  storage_class:
    name: <container_name>

by

  storage_class:
    name: <storage_class_name>
  storage_container:
    name: <storage_container_name>

And update deployment tasks with

  storage_class:
    name:"{{storage_class.name}}"
    storage_container: "{{storage_container.name}}"
@Golgautier Golgautier added the bug Something isn't working label Apr 5, 2023
@bhati-pradeep bhati-pradeep linked a pull request Jun 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants