Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Allow VM to be created using disk image without specifying size_gb #127

Closed
yannickstruyf3 opened this issue Feb 23, 2022 · 1 comment · Fixed by #131
Closed

[Bug] Allow VM to be created using disk image without specifying size_gb #127

yannickstruyf3 opened this issue Feb 23, 2022 · 1 comment · Fixed by #131
Assignees
@premkarat @alaa-bish @Gevorg-Khachatryan-97 @dina-abuhijleh
Labels
1.0 bug Something isn't working

Comments

@yannickstruyf3
Copy link
Collaborator

When creating a VM using a disk image, it is currently required to pass size_gb:

        disks:
          - type: "DISK"
            size_gb: 100
            clone_image:
              name: "{{image_name}}"

It should be possible to create a VM based on a disk_image without specifying the size_gb
@premkarat premkarat added 1.0 bug Something isn't working and removed feature labels Feb 23, 2022
@premkarat
Copy link
Collaborator

@Gevorg-Khachatryan-97 can you please quickly fix this and allow disk_image to be specified without size_gb.
@alaa-bish please modify the integration and unit tests to support this.

@premkarat premkarat changed the title [Feat] Allow VM to be created using disk image without specifying size_gb [Bug] Allow VM to be created using disk image without specifying size_gb Feb 23, 2022
Gevorg-Khachatryan-97 pushed a commit that referenced this issue Feb 23, 2022
#127 fixes for creating a VM based on a disk_image without specifying…
8de64a1 
… the size_gb
Gevorg-Khachatryan-97 added a commit that referenced this issue Feb 23, 2022
@Gevorg-Khachatryan-97
Merge pull request #131 from nutanix/imprv/vms
3692b2b 
#127 fixes for creating a VM based on a disk_image without specifying the size_gb
alaa-bish pushed a commit that referenced this issue Feb 24, 2022
@alaa-bish
#127 fixes for creating a VM based on a disk_image without specifying…
6a7b8eb 
… the size_gb
@premkarat premkarat linked a pull request Mar 1, 2022 that will close this issue
#127 fixes for creating a VM based on a disk_image without specifying the size_gb #131
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@premkarat premkarat

@alaa-bish alaa-bish

@Gevorg-Khachatryan-97 Gevorg-Khachatryan-97

@dina-abuhijleh dina-abuhijleh

Labels
1.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
5 participants
@premkarat @yannickstruyf3 @alaa-bish @Gevorg-Khachatryan-97 @dina-abuhijleh