Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.60 release checklist #4356

Closed
39 of 59 tasks
sophiajt opened this issue Jan 14, 2022 · 21 comments
Closed
39 of 59 tasks

0.60 release checklist #4356

sophiajt opened this issue Jan 14, 2022 · 21 comments
Labels
help wanted Extra attention is needed

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Jan 14, 2022

(warning: this list may not be complete, and may have items added as we discover them):

Commands

  • post - [efx]
  • benchmark (remaining: passthrough param)
  • match (regex type) (Jakub: I'd suggest folding it into find)
  • roll (roll, roll column, roll up)
  • headers
  • format filesize
  • chart (chart, chart bar, chart line)
  • histogram
  • reduce (parser support for $acc and $it instead of putting both inside $it)
  • save --append
  • group-by date (jt: this should probably be group-by --date since group-by date is ambiguous with a "date" as a column name')
  • into cell-path? (jt: is there a use case for this one? I think since e-q allows strings as cell-paths you might not need it?)
  • plug-ins: to bson, from bson
  • plug-ins: to sqlite, from sqlite
  • plug-ins: s3
  • plug-ins: binaryview (no need to port)
  • plug-ins: start
  • plug-ins: inc (still needs some work)

Features

  • finish custom external completions, git as main use case for initial design
  • generate a config.nu if it's not there Ask to generate a default config.nu if we don't find one #4348
  • lib_dirs (path for scripts, so use will look in these dirs)
  • LAST_EXIT_CODE to get the exit code of the last command (internal or external)
  • Update https://www.nushell.sh/book/command_reference.html
  • Automatic parsing of env vars (like PATH/Path) based on OS without needing config.nu
  • Cell-path completions About the table's autocomplete in new nushell #4372
  • Use kebab-case instead of snake_case for config points (jt: if column names are snake_case, then the config points would also be snake_case)
  • Use kebab-case instead of snake_case for cell paths (e.g., help commands) (jt: I think we ended up thinking column names should be snake_case. with that being true, cell paths would also be snake_case)
  • Update README

Missing config points - to add or not to add?

  • complete_from_path: bool
  • ctrlc_exit: bool
  • disable_table_indexes: bool
  • nonzero_exit_errors: bool
  • skip_welcome_message: bool (jt: we no longer show a welcome message, so this probably isn't needed?)
  • pivot_mode: auto, always, never (jt: because of records, some cases we needed this aren't needed anymore. I don't think we need this?)

3rd Party Integrations

We should ensure these are working or pr changes to their repo.

Document as "needs design" post-merge

CI / Repo Root folders

  • release ci - do we need any changes? wix, etc
  • winget ci
  • stale ci - keep or chunk?
  • wasm (won't block release if we don't get to it)

Bugs

Checks

@elferherrera
Copy link
Contributor

I would add a check for python's virtualenv

@fdncred
Copy link
Collaborator

fdncred commented Jan 14, 2022

Latest list of missing commands 1/12/2022
Last Updated 2/27/2022

missing commands status
command [autoenv trust] with parameter [dir] is missing in eq missing
command [autoenv trust] with parameter [quiet] is missing in eq missing
command [autoenv untrust] with parameter [dir] is missing in eq missing
command [autoenv untrust] with parameter [quiet] is missing in eq missing
command [benchmark] exists but parameter [passthrough] is missing in eq missing
command [chart bar] with parameter [columns] is missing in eq missing
command [chart bar] with parameter [format] is missing in eq missing
command [chart bar] with parameter [acc] is missing in eq missing
command [chart bar] with parameter [use] is missing in eq missing
command [chart line] with parameter [columns] is missing in eq missing
command [chart line] with parameter [format] is missing in eq missing
command [chart line] with parameter [acc] is missing in eq missing
command [chart line] with parameter [use] is missing in eq missing
command [dfr append] exists but parameter [axis] is missing in eq missing
command [dfr drop-duplicates] with parameter [subset] is missing in eq missing
command [dfr drop-duplicates] with parameter [maintain] is missing in eq missing
command [dfr unique] with parameter [period] is missing in eq missing
command [dfr replace] exists but parameter [length] is missing in eq missing
command [dfr replace] exists but parameter [start] is missing in eq missing
command [dfr where] with parameter [condition] is missing in eq missing
command [date format] exists but parameter [table] is missing in eq missing
command [date humanize] with parameter [table] is missing in eq missing
command [format filesize] with parameter [field] is missing in eq missing
command [format filesize] with parameter [format value] is missing in eq missing
command [from sqlite] with parameter [tables] is missing in eq missing
command [from xlsx] exists but parameter [noheaders] is missing in eq missing
command [group-by date] with parameter [column_name] is missing in eq missing
command [group-by date] with parameter [format] is missing in eq missing
command [hash] with parameter [rest] is missing in eq missing
command [histogram] with parameter [rest] is missing in eq missing
command [histogram] with parameter [use] is missing in eq missing
command [inc] exists but parameter [rest] is missing in eq missing
command [into column-path] with parameter [rest] is missing in eq missing
command [into path] with parameter [rest] is missing in eq missing - (* not sure if needed now)
command [load-env] with parameter [environ] is missing in eq missing
command [merge] with parameter [block] is missing in eq missing
command [nu plugin] with parameter [load] is missing in eq missing
command [pathvar] with parameter [var] is missing in eq missing
command [pathvar add] with parameter [path] is missing in eq missing
command [pathvar add] with parameter [var] is missing in eq missing
command [pathvar append] with parameter [path] is missing in eq missing
command [pathvar append] with parameter [var] is missing in eq missing
command [pathvar remove] with parameter [index] is missing in eq missing
command [pathvar remove] with parameter [var] is missing in eq missing
command [pathvar reset] with parameter [var] is missing in eq missing
command [pathvar save] with parameter [var] is missing in eq missing
command [s3] with parameter [RESOURCE] is missing in eq missing
command [s3] with parameter [raw] is missing in eq missing
command [s3] with parameter [endpoint] is missing in eq missing
command [s3] with parameter [access_key] is missing in eq missing
command [s3] with parameter [secret_key] is missing in eq missing
command [s3] with parameter [region] is missing in eq missing
command [save] with parameter [append] is missing in eq missing
command [start] with parameter [rest] is missing in eq missing
command [start] with parameter [application] is missing in eq missing
command [str] with parameter [rest] is missing in eq missing

@kubouch
Copy link
Contributor

kubouch commented Jan 16, 2022

TIL zip is already ported

@ghost
Copy link

ghost commented Jan 21, 2022

I will try porting find
nushell/engine-q#658 is WIP 😄

@lukexor
Copy link

lukexor commented Jan 25, 2022

Also add that starship works but not out of the box with the default line_break module enabled. See nushell/engine-q#575

Work-around:

let-env PROMPT_COMMAND = { starship prompt | decode utf8 | str find-replace -a (char newline) (char crlf) }

@eggcaker
Copy link
Contributor

I'm not sure I can do, but I want to try to learn more with just port a simple command , like du ?

@fdncred
Copy link
Collaborator

fdncred commented Jan 28, 2022

I'm not sure I can do, but I want to try to learn more with just port a simple command , like du ?

go for it. just copy it from nushell and try to change the primitive types to engine-q types. This issue has some tips at the bottom. nushell/engine-q#242

@eggcaker
Copy link
Contributor

@fdncred did you add my name to the du command already, could you remove for now, seems lot of thing need to learn about nushell and rust .

@fdncred
Copy link
Collaborator

fdncred commented Jan 30, 2022

@fdncred did you add my name to the du command already, could you remove for now, seems lot of thing need to learn about nushell and rust .

sure. no worries.

@fdncred fdncred transferred this issue from nushell/engine-q Feb 7, 2022
@kubouch kubouch pinned this issue Feb 8, 2022
@kubouch kubouch changed the title Engine-q final merge checklist 0.60 release checklist Feb 8, 2022
@lukexor
Copy link

lukexor commented Feb 14, 2022

Is autoenv being postponed for release? If so it needs to get added to the breaking changes list. It's a critical feature for my every day work and I'd assume for others as well even for those who don't use python. I have several node and java projects with varying versions that I jump between.

@kubouch
Copy link
Contributor

kubouch commented Feb 14, 2022

@lukexor Yes, we're leaving autoenv out for the 0.60 release and will re-introduce it later. BTW, what is your use case for autoenv? Do you use it to define environment variables only? Or do you define also custom commands?

@lukexor
Copy link

lukexor commented Feb 15, 2022

@kubouch Primarily modifying PATH and env vars like JAVA_HOME. Custom commands aren't a concern and have alternative work arounds. At present my only work around is a custom cd command or manually sourcing a nu file

@ghost ghost mentioned this issue Feb 18, 2022
3 tasks
sophiajt pushed a commit that referenced this issue Feb 18, 2022
This restores a basic version of the `post` command.
Some source types have been omitted from this first take.
I copied from `fetch` and from `post`@0.40.0.
Part of #4356
@hustcer
Copy link
Contributor

hustcer commented Feb 23, 2022

What's the status of match command ?

@fdncred
Copy link
Collaborator

fdncred commented Feb 23, 2022

What's the status of match command ?

we're looking for someone to port it and integrate that functionality into find. are you interested?

@hustcer
Copy link
Contributor

hustcer commented Feb 24, 2022

@fdncred I'm interested in this, but I'm not familiar with Rust and if I were to develop it, it might take longer than expected. BTW, I don't know much about the overall architecture of the new engine. Is there a developer guide for the new engine? I think I've seen it somewhere, but I don't remember now.

@fdncred
Copy link
Collaborator

fdncred commented Feb 24, 2022

I don't want you to get overloaded. it would be nice to finish the examples first, if you don't mind. If you're not interested in finishing the examples, that's ok too. just let me know.

@hustcer
Copy link
Contributor

hustcer commented Feb 24, 2022

@fdncred Sure, I will add examples for n/p/g/grid soon.
And It will take me some time to learn the other commands: extern, run-external

@fdncred fdncred added the help wanted Extra attention is needed label Feb 27, 2022
@fdncred
Copy link
Collaborator

fdncred commented Mar 7, 2022

@jaeheonji i'll delete it when the other issue is up. thank you for helping us!

@jaeheonji
Copy link
Contributor

@fdncred Cool! thank you 😄 I'll try to create an issue ASAP.

@nushell nushell deleted a comment from jaeheonji Mar 7, 2022
@nushell nushell deleted a comment from jaeheonji Mar 7, 2022
@sophiajt sophiajt unpinned this issue Apr 8, 2022
@devurandom
Copy link

0.60 has long been released. Can this issue be closed?

@fdncred
Copy link
Collaborator

fdncred commented Aug 9, 2022

ya, we should probably close it. there are things still not ported but apparently no one really needs that funcitonality.

@fdncred fdncred closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

9 participants