You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a result, Collision can crash the application (quietly, since we literally just removed the default error-handler), leading to (amongst others) empty php artisan output.
While the goal of this library is obviously to have error reporting, I'd argue that even without error reporting enabled in your app, Collision shouldn't be the one causing the crashes. Instead, it should probably skip service provider registration (since the package is installed, but error reporting is currently disabled)
Since Laravel 11, the
bootstrap/app.php
file has the following lines included by default:Theoretically, if you don't want an exception handler, you should be able to remove these lines (except for the
->create()
chain, of course), and the (console) app should still run just fine. However, Collision currently blindly assumes this binding is always there: https://github.com/nunomaduro/collision/blob/v8.x/src/Adapters/Laravel/CollisionServiceProvider.php#L61As a result, Collision can crash the application (quietly, since we literally just removed the default error-handler), leading to (amongst others) empty
php artisan
output.While the goal of this library is obviously to have error reporting, I'd argue that even without error reporting enabled in your app, Collision shouldn't be the one causing the crashes. Instead, it should probably skip service provider registration (since the package is installed, but error reporting is currently disabled)
The text was updated successfully, but these errors were encountered: