Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Is.String* Constraints #2342

Closed
ChrisMaddock opened this issue Aug 1, 2017 · 2 comments
Closed

Remove deprecated Is.String* Constraints #2342

ChrisMaddock opened this issue Aug 1, 2017 · 2 comments
Assignees
@OmicronPersei
Labels
help wanted is:enhancement pri:high
Milestone
3.8

Comments

@ChrisMaddock
Copy link
Member

#2338 removed the attributes obsoleted in v3.0.

I suggest we also remove the Is.String* constraints which were deprecated at the same time - and do this in the 3.8 release, so we only inconvenience users the once.
@ChrisMaddock ChrisMaddock added this to the 3.8 milestone Aug 1, 2017
@CharliePoole
Copy link
Member

I've never been happy with our syntax for the four string constraints, but the Is.String* items should definitely go.

@stevenaw stevenaw mentioned this issue Aug 2, 2017
Closed
@OmicronPersei
Copy link
Contributor

While I wait for more info on #2226 I'll work on this 😛

@OmicronPersei OmicronPersei self-assigned this Aug 10, 2017
@OmicronPersei OmicronPersei mentioned this issue Aug 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OmicronPersei OmicronPersei

Labels
help wanted is:enhancement pri:high
Projects
None yet
Milestone
3.8
Development

No branches or pull requests
3 participants
@CharliePoole @ChrisMaddock @OmicronPersei