Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8 Console and Agent #1378

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

mlessmann
Copy link

  • Use .NET 8 SDK in global.json
  • Add .NET 8 target to nunit-console and nunit-engine-core
  • Add .NET 8 and 7 target to nunit-agent
  • Selectively disable NuGet audit to suppress errors when building for .NET Core 2.1
  • Adjusted cake scripts

See #1374

@mlessmann
Copy link
Author

@dotnet-policy-service agree company="dSPACE GmbH"

Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can't see anything that seems out of place.

@OsirisTerje OsirisTerje merged commit b423d3f into nunit:version315 Jan 11, 2024
2 checks passed
@CharliePoole
Copy link
Collaborator

CharliePoole commented Jun 27, 2024

@OsirisTerje @mlessmann
I'm a bit confused, as I was about to add a .NET 8.0 agent for 3.18.

For some reason, this PR was merged into branch 3.15 and is also now in main, but I can't figure out how it got there.
It wasn't in release 3.17. I think this also applies to other work that @mlessmann did and I'd like to straighten it out. At a minimum, I'll create a "retroactive issue" for 3.18, so that the release notes show it as being added and @mlessmann is credited.

@mlessmann I think this also applies to some other commits you made, which I'm investigating. Can we set up a channel to communicate without using issue comments? My email is on my GitHub profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants